[PATCH v4 07/25] reboot: Remove extern annotation from function prototypes
Dmitry Osipenko
digetx at gmail.com
Fri Dec 10 10:15:57 PST 2021
10.12.2021 21:09, Rafael J. Wysocki пишет:
> On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko <digetx at gmail.com> wrote:
>>
>> There is no need to annotate function prototypes with 'extern', it makes
>> code less readable. Remove unnecessary annotations from <reboot.h>.
>>
>> Signed-off-by: Dmitry Osipenko <digetx at gmail.com>
>
> I'm not sure that this is really useful.
>
> Personally, I tend to respect the existing conventions like this.
>
> Surely, this change is not required for the rest of the series to work.
Problem that such things start to spread all over the kernel with a
copy-paste approach if there is nobody to clean up the code.
This is not a common convention and sometimes it's getting corrected [1].
[1] https://git.kernel.org/linus/6d7434931
More information about the linux-riscv
mailing list