[PATCH v3 2/5] RISC-V: Add kexec support

[Nick Kossifidis]

Στις 2021-04-06 21:38, Alex Ghiti έγραψε:
> Le 4/5/21 à 4:57 AM, Nick Kossifidis a écrit :
>> +
>> +/* Reserve a page for the control code buffer */
>> +#define KEXEC_CONTROL_PAGE_SIZE 4096
> 
> PAGE_SIZE instead ?
> 

Yup, I'll change it.

>> +obj-${CONFIG_KEXEC}		+= kexec_relocate.o machine_kexec.o
> 
> Other obj-$() use parenthesis.
> 

ACK

>> +	li	s5, ((1 << PAGE_SHIFT) / RISCV_SZPTR)
> 
> 1 << PAGE_SHIFT = PAGE_SIZE
> 

ACK

>> +#if defined(CONFIG_HOTPLUG_CPU) && (CONFIG_SMP)
> 
> Shouldn't it be defined(CONFIG_SMP) ?
> 

It depends on SMP anyway, I'll remove the second part.