get_cycles from modular code in jitterentropy, was Re: [PATCH] clocksource: clint: Export clint_time_val for modules
Stephan Mueller
smueller at chronox.de
Fri Oct 2 02:55:04 EDT 2020
Am Freitag, 2. Oktober 2020, 08:49:05 CEST schrieb Christoph Hellwig:
Hi Christoph,
> On Tue, Sep 29, 2020 at 11:56:18PM -0700, Palmer Dabbelt wrote:
> > clint_time_val will soon be used by the RISC-V implementation of
> > random_get_entropy(), which is a static inline function that may be used
> > by
> > modules (at least CRYPTO_JITTERENTROPY=m).
>
> At very least this needs to be an EXPORT_SYMBOL_GPL. But I really don't
> think modules have any business using get_cycles, so I'd much rather
> fix CRYPTO_JITTERENTROPY to be required to be build in.
Changing CRYPTO_JITTERENTROPY from tistate to bool should be no problem.
I will provide a patch.
Ciao
Stephan
More information about the linux-riscv
mailing list