[PATCH 4/5] kgdb: Move the extern declaration kgdb_has_hit_break() to generic kgdb.h

[Daniel Thompson]

On Tue, Jun 23, 2020 at 01:37:25PM +0800, Vincent Chen wrote:
> Currently, only riscv kgdb.c uses the kgdb_has_hit_break() to identify
> the kgdb breakpoint. It causes other architectures will encounter the "no
> previous prototype" warnings if the compile option has W=1. Moving the
> declaration of extern kgdb_has_hit_break() from risc-v kgdb.h to generic
> kgdb.h to avoid generating these warnings.
> 
> Signed-off-by: Vincent Chen <vincent.chen at sifive.com>

Acked-by: Daniel Thompson <daniel.thompson at linaro.org>
(Enthusiastically)


Daniel.

> ---
>  arch/riscv/include/asm/kgdb.h | 1 -
>  include/linux/kgdb.h          | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/include/asm/kgdb.h b/arch/riscv/include/asm/kgdb.h
> index 8177a457caff..f45889bbb965 100644
> --- a/arch/riscv/include/asm/kgdb.h
> +++ b/arch/riscv/include/asm/kgdb.h
> @@ -19,7 +19,6 @@
>  
>  #ifndef	__ASSEMBLY__
>  
> -extern int kgdb_has_hit_break(unsigned long addr);
>  extern unsigned long kgdb_compiled_break;
>  
>  static inline void arch_kgdb_breakpoint(void)
> diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h
> index c0c239202cee..b2775d96f843 100644
> --- a/include/linux/kgdb.h
> +++ b/include/linux/kgdb.h
> @@ -326,6 +326,7 @@ extern int kgdb_hex2mem(char *buf, char *mem, int count);
>  
>  extern int kgdb_isremovedbreak(unsigned long addr);
>  extern void kgdb_schedule_breakpoint(void);
> +extern int kgdb_has_hit_break(unsigned long addr);
>  
>  extern int
>  kgdb_handle_exception(int ex_vector, int signo, int err_code,
> -- 
> 2.7.4
>