[PATCH v2 1/5] mbox: add polarfire soc system controller mailbox

[Jonathan Neuschäfer]

On Tue, Dec 01, 2020 at 11:02:42AM +0000, conor.dooley at microchip.com wrote:
> From: Conor Dooley <conor.dooley at microchip.com>
> 
> This driver adds support for the single mailbox channel of the MSS
> system controller on the Microchip PolarFire SoC.

Out of my curiosity: What is MSS? Is it the Microprocessor Subsystem in
the SoC?

(It isn't quite clear from the PolarFire documentation I could find)

> 
> Signed-off-by: Conor Dooley <conor.dooley at microchip.com>
> ---
[...]
> +config MPFS_MBOX
> +	tristate "MPFS Mailbox"

"MPFS" in the title seems (to me) a bit too obscure for the uninitiated.
Perhaps you could use something slightly longer that mentions Microchip
and/or the PolarFire series?

> +++ b/drivers/mailbox/mailbox-mpfs.c
> @@ -0,0 +1,285 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Microchip MPFS system controller/mailbox controller driver

The same might apply here.


Best regards,
Jonathan Neuschäfer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20201201/6d268525/attachment.sig>