[PATCH v3 5/5] RISC-V: Avoid corrupting the upper 32-bit of phys_addr_t in ioremap

Zong Li zongbox at gmail.com
Tue Oct 2 20:26:43 PDT 2018


Christoph Hellwig <hch at infradead.org> 於 2018年10月2日 週二 下午10:51寫道:
>
> On Tue, Oct 02, 2018 at 04:52:31PM +0800, Zong Li wrote:
> > From: Vincent Chen <vincentc at andestech.com>
> >
> > For 32bit, the upper 32-bit of phys_addr_t will be flushed to zero
> > after AND with PAGE_MASK because the data type of PAGE_MASK is
> > unsigned long. To fix this problem, the page alignment is done by
> > subtracting the page offset instead of AND with PAGE_MASK.
> >
> > Signed-off-by: Vincent Chen <vincentc at andestech.com>
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
>
> (and I'm pretty sure I reviewed this before..)

Hi Christoph,

Very sorry about that. I didn't notice I lose these review tags. Could
you please help to review again in version 4 patches? Thank you.

Regards,
Zong



More information about the linux-riscv mailing list