[PATCH v9 02/12] drivers: base: cacheinfo: setup DT cache properties early

Sudeep Holla sudeep.holla at arm.com
Wed May 16 03:56:26 PDT 2018

Hi Andy,

On 15/05/18 20:32, Andy Shevchenko wrote:
> On Tue, May 15, 2018 at 8:15 PM, Jeremy Linton <jeremy.linton at arm.com> wrote:
>> On 05/11/2018 06:57 PM, Jeremy Linton wrote:
>>>   -     cache_size = of_get_property(this_leaf->of_node, propname, NULL);
>>> +       cache_size = of_get_property(np, propname, NULL);
>>>         if (cache_size)
>>>                 this_leaf->size = of_read_number(cache_size, 1);
> Can't you switch to of_read_property_uXX() variant here?

This patch is just changing the first argument to the calls. So if we
need to change, it has to be separate patch.

Now, we can use of_property_read_u64() but is there any particular
reason you mention that ? One reason I can see is that we can avoid
making explicit of_get_property call. Just wanted to the motive before I
can write the patch.


More information about the linux-riscv mailing list