[PATCH v4 14/16] powerpc: Use generic free_initrd_mem.

Shea Levy shea at shealevy.com
Sun Apr 1 08:01:36 PDT 2018

Hi Michael,

Michael Ellerman <mpe at ellerman.id.au> writes:

> Shea Levy <shea at shealevy.com> writes:
>> Joe Perches <joe at perches.com> writes:
>>> On Wed, 2018-03-28 at 16:36 -0400, Shea Levy wrote:
>>>> Signed-off-by: Shea Levy <shea at shealevy.com>
>>> Most people seem to want some form of commit message
>>> and not just your sign-off.
>> Ah, if the subject is insufficient I can add some more detail.
> Yeah please do.
> Seeing this patch in isolation, with no change log, I might think it's
> safe for me to just apply it.
> But that would break the build because I don't have patch 1.
> So for starters you need to explain that part, eg something like:
>   A previous patch in the series added a weak definition of
>   free_initrd_mem() in init/initramfs.c.
>   The powerpc implementation is identical, so it can be removed allowing
>   the generic version to be used.
> Then you could also tell me if you did/didn't build/boot test it.

Thanks for the feedback, can you let me know if the recently posted v6
fits the bill?

> cheers

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20180401/26d89962/attachment.sig>

More information about the linux-riscv mailing list