From afaerber at suse.de Wed May 19 15:31:11 2021 From: afaerber at suse.de (=?UTF-8?Q?Andreas_F=c3=a4rber?=) Date: Wed, 19 May 2021 16:31:11 +0200 Subject: [PATCH 3/4] arm64: dts: realtek: rtd16xx: normalize the node name of the UART devices In-Reply-To: <20210519141914.8044-4-thunder.leizhen@huawei.com> References: <20210519141914.8044-1-thunder.leizhen@huawei.com> <20210519141914.8044-4-thunder.leizhen@huawei.com> Message-ID: <8e79d8d9-c2c7-32f3-e2be-e5d288cebf0a@suse.de> Hi, On 19.05.21 16:19, Zhen Lei wrote: > Change the node name of the UART devices to match > "^serial(@[0-9a-f,]+)*$". > > Signed-off-by: Zhen Lei > --- > arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi > index afba5f04c8ec..bf4d9e917925 100644 > --- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi > +++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi > @@ -195,7 +195,7 @@ > }; > > &iso { > - uart0: serial0 at 800 { > + uart0: serial at 800 { [snip] Ouch, shame on me for not catching this in review... Reviewed-by: Andreas F?rber Are you expecting this to go through the four maintainer trees or centrally somehow? Thanks, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer HRB 36809 (AG N?rnberg) From f.fainelli at gmail.com Thu May 20 19:45:47 2021 From: f.fainelli at gmail.com (Florian Fainelli) Date: Thu, 20 May 2021 11:45:47 -0700 Subject: [PATCH 2/4] arm64: dts: broadcom: normalize the node name of the UART devices In-Reply-To: <20210519141914.8044-3-thunder.leizhen@huawei.com> References: <20210519141914.8044-1-thunder.leizhen@huawei.com> <20210519141914.8044-3-thunder.leizhen@huawei.com> Message-ID: <20210520184547.2137680-1-f.fainelli@gmail.com> On Wed, 19 May 2021 22:19:12 +0800, Zhen Lei wrote: > Change the node name of the UART devices to match > "^serial(@[0-9a-f,]+)*$". > > Signed-off-by: Zhen Lei > --- Applied to devicetree-arm64/next, thanks! -- Florian From thunder.leizhen at huawei.com Wed May 19 15:19:10 2021 From: thunder.leizhen at huawei.com (Zhen Lei) Date: Wed, 19 May 2021 22:19:10 +0800 Subject: [PATCH 0/4] Clear some dtbs_check warnings detected by snps-dw-apb-uart.yaml Message-ID: <20210519141914.8044-1-thunder.leizhen@huawei.com> The Synopsys DesignWare ABP UART is commonly used. Therefore, it is meaningful to clear the warnings detected by snps-dw-apb-uart.yaml. I fixed everything I could. The only problem left is that some serial port nodes do not have the property 'interrupts'. I don't know their interrupt number, so there's no way to fix it. By the way, is there a scenario where serial ports do not need to be interrupted? If it exists, property 'interrupts' should not be defined as required. Zhen Lei (4): arm64: dts: bitmain: normalize the node name of the UART devices arm64: dts: broadcom: normalize the node name of the UART devices arm64: dts: realtek: rtd16xx: normalize the node name of the UART devices arm64: dts: synaptics: normalize the node name of the UART devices arch/arm64/boot/dts/bitmain/bm1880.dtsi | 6 +++--- arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi | 8 ++++---- arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++--- arch/arm64/boot/dts/synaptics/berlin4ct.dtsi | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) -- 2.21.1 From thunder.leizhen at huawei.com Wed May 19 15:19:12 2021 From: thunder.leizhen at huawei.com (Zhen Lei) Date: Wed, 19 May 2021 22:19:12 +0800 Subject: [PATCH 2/4] arm64: dts: broadcom: normalize the node name of the UART devices In-Reply-To: <20210519141914.8044-1-thunder.leizhen@huawei.com> References: <20210519141914.8044-1-thunder.leizhen@huawei.com> Message-ID: <20210519141914.8044-3-thunder.leizhen@huawei.com> Change the node name of the UART devices to match "^serial(@[0-9a-f,]+)*$". Signed-off-by: Zhen Lei --- arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi index 2ffb2c92182a..7b04dfe67bef 100644 --- a/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi +++ b/arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi @@ -470,7 +470,7 @@ status = "disabled"; }; - uart0: uart at 100000 { + uart0: serial at 100000 { device_type = "serial"; compatible = "snps,dw-apb-uart"; reg = <0x00100000 0x1000>; @@ -481,7 +481,7 @@ status = "disabled"; }; - uart1: uart at 110000 { + uart1: serial at 110000 { device_type = "serial"; compatible = "snps,dw-apb-uart"; reg = <0x00110000 0x1000>; @@ -492,7 +492,7 @@ status = "disabled"; }; - uart2: uart at 120000 { + uart2: serial at 120000 { device_type = "serial"; compatible = "snps,dw-apb-uart"; reg = <0x00120000 0x1000>; @@ -503,7 +503,7 @@ status = "disabled"; }; - uart3: uart at 130000 { + uart3: serial at 130000 { device_type = "serial"; compatible = "snps,dw-apb-uart"; reg = <0x00130000 0x1000>; -- 2.21.1 From thunder.leizhen at huawei.com Wed May 19 15:19:14 2021 From: thunder.leizhen at huawei.com (Zhen Lei) Date: Wed, 19 May 2021 22:19:14 +0800 Subject: [PATCH 4/4] arm64: dts: synaptics: normalize the node name of the UART devices In-Reply-To: <20210519141914.8044-1-thunder.leizhen@huawei.com> References: <20210519141914.8044-1-thunder.leizhen@huawei.com> Message-ID: <20210519141914.8044-5-thunder.leizhen@huawei.com> Change the node name of the UART devices to match "^serial(@[0-9a-f,]+)*$". Signed-off-by: Zhen Lei --- arch/arm64/boot/dts/synaptics/berlin4ct.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi b/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi index 0949acee4728..dc12350b9fc8 100644 --- a/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi +++ b/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi @@ -289,7 +289,7 @@ }; }; - uart0: uart at d000 { + uart0: serial at d000 { compatible = "snps,dw-apb-uart"; reg = <0xd000 0x100>; interrupts = <8>; -- 2.21.1 From thunder.leizhen at huawei.com Wed May 19 15:19:11 2021 From: thunder.leizhen at huawei.com (Zhen Lei) Date: Wed, 19 May 2021 22:19:11 +0800 Subject: [PATCH 1/4] arm64: dts: bitmain: normalize the node name of the UART devices In-Reply-To: <20210519141914.8044-1-thunder.leizhen@huawei.com> References: <20210519141914.8044-1-thunder.leizhen@huawei.com> Message-ID: <20210519141914.8044-2-thunder.leizhen@huawei.com> Change the node name of the UART devices to match "^serial(@[0-9a-f,]+)*$". Signed-off-by: Zhen Lei --- arch/arm64/boot/dts/bitmain/bm1880.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/bitmain/bm1880.dtsi b/arch/arm64/boot/dts/bitmain/bm1880.dtsi index 53a9b76057aa..22a200fb07d2 100644 --- a/arch/arm64/boot/dts/bitmain/bm1880.dtsi +++ b/arch/arm64/boot/dts/bitmain/bm1880.dtsi @@ -184,7 +184,7 @@ status = "disabled"; }; - uart1: serial at 5801A000 { + uart1: serial at 5801a000 { compatible = "snps,dw-apb-uart"; reg = <0x0 0x5801a000 0x0 0x2000>; clocks = <&clk BM1880_CLK_UART_500M>, @@ -197,7 +197,7 @@ status = "disabled"; }; - uart2: serial at 5801C000 { + uart2: serial at 5801c000 { compatible = "snps,dw-apb-uart"; reg = <0x0 0x5801c000 0x0 0x2000>; clocks = <&clk BM1880_CLK_UART_500M>, @@ -210,7 +210,7 @@ status = "disabled"; }; - uart3: serial at 5801E000 { + uart3: serial at 5801e000 { compatible = "snps,dw-apb-uart"; reg = <0x0 0x5801e000 0x0 0x2000>; clocks = <&clk BM1880_CLK_UART_500M>, -- 2.21.1 From thunder.leizhen at huawei.com Wed May 19 15:19:13 2021 From: thunder.leizhen at huawei.com (Zhen Lei) Date: Wed, 19 May 2021 22:19:13 +0800 Subject: [PATCH 3/4] arm64: dts: realtek: rtd16xx: normalize the node name of the UART devices In-Reply-To: <20210519141914.8044-1-thunder.leizhen@huawei.com> References: <20210519141914.8044-1-thunder.leizhen@huawei.com> Message-ID: <20210519141914.8044-4-thunder.leizhen@huawei.com> Change the node name of the UART devices to match "^serial(@[0-9a-f,]+)*$". Signed-off-by: Zhen Lei --- arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi index afba5f04c8ec..bf4d9e917925 100644 --- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi +++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi @@ -195,7 +195,7 @@ }; &iso { - uart0: serial0 at 800 { + uart0: serial at 800 { compatible = "snps,dw-apb-uart"; reg = <0x800 0x400>; reg-shift = <2>; @@ -207,7 +207,7 @@ }; &misc { - uart1: serial1 at 200 { + uart1: serial at 200 { compatible = "snps,dw-apb-uart"; reg = <0x200 0x400>; reg-shift = <2>; @@ -217,7 +217,7 @@ status = "disabled"; }; - uart2: serial2 at 400 { + uart2: serial at 400 { compatible = "snps,dw-apb-uart"; reg = <0x400 0x400>; reg-shift = <2>; -- 2.21.1 From thunder.leizhen at huawei.com Wed May 19 15:46:29 2021 From: thunder.leizhen at huawei.com (Leizhen (ThunderTown)) Date: Wed, 19 May 2021 22:46:29 +0800 Subject: [PATCH 3/4] arm64: dts: realtek: rtd16xx: normalize the node name of the UART devices In-Reply-To: <8e79d8d9-c2c7-32f3-e2be-e5d288cebf0a@suse.de> References: <20210519141914.8044-1-thunder.leizhen@huawei.com> <20210519141914.8044-4-thunder.leizhen@huawei.com> <8e79d8d9-c2c7-32f3-e2be-e5d288cebf0a@suse.de> Message-ID: On 2021/5/19 22:31, Andreas F?rber wrote: > Hi, > > On 19.05.21 16:19, Zhen Lei wrote: >> Change the node name of the UART devices to match >> "^serial(@[0-9a-f,]+)*$". >> >> Signed-off-by: Zhen Lei >> --- >> arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi >> index afba5f04c8ec..bf4d9e917925 100644 >> --- a/arch/arm64/boot/dts/realtek/rtd16xx.dtsi >> +++ b/arch/arm64/boot/dts/realtek/rtd16xx.dtsi >> @@ -195,7 +195,7 @@ >> }; >> >> &iso { >> - uart0: serial0 at 800 { >> + uart0: serial at 800 { > [snip] > > Ouch, shame on me for not catching this in review... > > Reviewed-by: Andreas F?rber > > Are you expecting this to go through the four maintainer trees or > centrally somehow? It would be nice for each maintainer to add its own patch to its own tree. Each patch is independent, I put these four patches together just for the convenience of describing 0000-cover-letter > > Thanks, > Andreas >