[PATCH 02/14] PMFS: Remove pmfs_sb.h

Matthew Wilcox willy at linux.intel.com
Wed Oct 9 16:54:56 EDT 2013

On Wed, Oct 09, 2013 at 11:45:50AM -0600, Ross Zwisler wrote:
> > -#include "wprotect.h"
> Is there a benefit from moving the #include for wprotect.h from here down to
> the end of the file?

Necessary for it to build ... wprotect.h relies on the definition
of pmfs_sb_info.  I moved it to the place that those functions would
logically live if they were inlined.  We can discuss moving wprotect.h
into pmfs.h if you like :-)

> Also, a little checkpatch hate that we may want to fix while we're in here:
> WARNING: please, no space before tabs
> #125: FILE: fs/pmfs/pmfs.h:277:
> +^Istruct mutex ^Is_lock;^I/* protects the SB's buffer-head */$

Let's do that separately ... fixing all the checkpatch issues is on the
todo list so it won't get forgotten.

More information about the Linux-pmfs mailing list