[PATCH 1/3] PMFS: Remove BUG() from pmfs_dirty_inode

Ross Zwisler ross.zwisler at linux.intel.com
Wed Jun 19 19:56:34 EDT 2013


From: Vishal Verma <vishal.l.verma at linux.intel.com>

This check may not be required. For now keep a ratelimited printk.

Signed-off-by: Vishal Verma <vishal.l.verma at linux.intel.com>
Signed-off-by: Ross Zwisler <ross.zwisler at linux.intel.com>
Reviewed-by: Matthew Wilcox <matthew.r.wilcox at intel.com>
---
 fs/pmfs/inode.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/pmfs/inode.c b/fs/pmfs/inode.c
index 4d22af0..b13560d 100644
--- a/fs/pmfs/inode.c
+++ b/fs/pmfs/inode.c
@@ -20,6 +20,7 @@
 #include <linux/mpage.h>
 #include <linux/backing-dev.h>
 #include <linux/types.h>
+#include <linux/ratelimit.h>
 #include "pmfs.h"
 #include "xip.h"
 
@@ -1238,8 +1239,9 @@ void pmfs_dirty_inode(struct inode *inode, int flags)
 	pmfs_memlock_inode(sb, pi);
 	pmfs_flush_buffer(&pi->i_atime, sizeof(pi->i_atime), true);
 
+	/* FIXME: Is this check needed? */
 	if (pmfs_is_inode_dirty(inode, pi))
-		BUG();
+		printk_ratelimited(KERN_ERR "pmfs: inode was dirty!\n");
 }
 
 /*
-- 
1.8.2.GIT




More information about the Linux-pmfs mailing list