[PATCH v4 1/3] PMFS: Remove BUG() from pmfs_dirty_inode

Vishal Verma vishal.l.verma at linux.intel.com
Tue Jun 11 14:28:18 EDT 2013


This check may not be required. For now keep a ratelimited printk.

Signed-off-by: Vishal Verma <vishal.l.verma at linux.intel.com>
---
 fs/pmfs/inode.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/pmfs/inode.c b/fs/pmfs/inode.c
index 35d3b43..ea10bd9 100644
--- a/fs/pmfs/inode.c
+++ b/fs/pmfs/inode.c
@@ -1238,8 +1238,10 @@ void pmfs_dirty_inode(struct inode *inode, int flags)
 	pmfs_memlock_inode(sb, pi);
 	pmfs_flush_buffer(&pi->i_atime, sizeof(pi->i_atime), true);
 
+	/* FIXME: Is this check needed? */
 	if (pmfs_is_inode_dirty(inode, pi))
-		BUG();
+		if(printk_ratelimit())
+			printk(KERN_ERR "pmfs: inode was dirty!\n");
 }
 
 /*
-- 
1.7.0.4




More information about the Linux-pmfs mailing list