[PATCH v4 2/3] dt-bindings: media: qcom,glymur-camss: Add Glymur CAMSS

[sashiko-bot at kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: validation failure due to missing phy@ child nodes and cell properties
--

commit 2c100de42ea1bb8c2267da0512e16ed0f56b5334
Author: Nihal Kumar Gupta <nihal.gupta at oss.qualcomm.com>

dt-bindings: media: qcom,glymur-camss: Add Glymur CAMSS

This commit introduces the device tree binding for the Qualcomm Glymur Camera
Subsystem (CAMSS). It specifies the required resources and ports. The commit
message indicates that Glymur uses the new PHY API via standalone phy@ child
nodes.

> diff --git a/Documentation/devicetree/bindings/media/qcom,glymur-camss.yaml b/Documentation/devicetree/bindings/media/qcom,glymur-camss.yaml
> new file mode 100644
> index 0000000000000..a0b77edc21231
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,glymur-camss.yaml
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - clocks
> +  - clock-names
> +  - interrupts
> +  - interrupt-names
> +  - interconnects
> +  - interconnect-names
> +  - iommus
> +  - power-domains
> +  - power-domain-names
> +  - ports
> +
> +additionalProperties: false

[Severity: Medium]
The commit message mentions that Glymur uses the new PHY API via standalone
phy@ child nodes. Since additionalProperties is set to false here, and there
are no definitions for phy@ child nodes or their associated properties like
#address-cells, #size-cells, or ranges, will this cause dt-validate to reject
device trees that implement these child nodes?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-glymur_camss-v4-0-d7c2983d6d7b@oss.qualcomm.com?part=2