[PATCH v4 3/6] PCI: qcom: Add Nord PCIe controller support
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Sun Sep 20 22:46:05 PDT 2026
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] pci: qcom: missing kernel-doc for disable_cgc in struct qcom_pcie_cfg
--
commit e586f6bf039bd0cdbc21480739c4165ddb038509
Author: Krishna Chaitanya Chundru <krishna.chundru at oss.qualcomm.com>
PCI: qcom: Add Nord PCIe controller support
Add the Nord PCIe controller configuration and the platform-specific settings
required for correct operation. Includes a clock-gating workaround and disables
L0s, as documented in a private erratum.
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index b58a607b713f5..304628b57f33b 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -281,6 +281,7 @@ struct qcom_pcie_cfg {
> bool override_no_snoop;
> bool firmware_managed;
> bool no_l0s;
> + bool disable_cgc;
> };
[Severity: Low]
Should this new field be documented in the accompanying kernel-doc block?
The struct qcom_pcie_cfg has a kernel-doc comment block that explicitly
documents its members. The new disable_cgc field was not added to the
kernel-doc block, which leaves the struct documentation incomplete and will
trigger kernel-doc script warnings.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-nord-v4-0-ed05c6e09240@oss.qualcomm.com?part=3
More information about the linux-phy
mailing list