[PATCH net-next v4 07/10] net: pcs: xpcs: add Rockchip RK3568 platform glue driver

[Coia Prant]

<sashiko-bot at kernel.org> 于2026年9月8日周二 23:41写道：
>
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [High] A Time-of-Check to Time-of-Use (TOCTOU) race condition in xpcs_rk_create allows a concurrent unbind of the supplier to free the MDIO bus, leading to a Use-After-Free.
> - [Medium] Incorrect LIFO teardown ordering in devres clock cleanup action violates proper device initialization and PM hierarchy rules.
> --
>
> commit 7142dbf6b28b5ee94d0edc969bcf16d1183a5f41
> Author: Coia Prant <coiaprant at gmail.com>
>
> net: pcs: xpcs: add Rockchip RK3568 platform glue driver
>
> This commit adds a platform glue driver for the Synopsys DesignWare xpcs
> integrated in the Rockchip RK3568 SoC. It creates a virtual mdio bus to
> translate mdio operations to apb3 memory-mapped register accesses.
>
> Link: https://dl.radxa.com/rock3/docs/hw/datasheet/Rockchip%20RK3568%20TRM%20Part2%20V1.1-20210301.pdf (Page 2078)
>
> > diff --git a/drivers/net/pcs/pcs-xpcs-rk.c b/drivers/net/pcs/pcs-xpcs-rk.c
> > new file mode 100644
> > index 0000000000000..68bcaa1a5cbbf
> > --- /dev/null
> > +++ b/drivers/net/pcs/pcs-xpcs-rk.c
> [ ... ]
> > +static void xpcs_rk_exit_clk(void *data)
> > +{
> > +     struct dw_xpcs_rk *pxpcs = data;
> > +     struct device *dev = &pxpcs->pdev->dev;
> > +
> > +     clk_disable_unprepare(pxpcs->eee_clk);
> > +
> > +     pm_runtime_force_suspend(dev);
>
> [Severity: Medium]
> Does this sequence result in the clock being disabled before the device is
> suspended?
>
> In xpcs_rk_init_clk(), eee_clk is enabled first, followed by a call to
> pm_runtime_enable(), allowing the device to become runtime active. During
> teardown, pm_runtime_force_suspend() invokes xpcs_rk_pm_runtime_suspend()
> to disable csr_clk.
>
> Calling clk_disable_unprepare() for eee_clk before pm_runtime_force_suspend()
> violates last-in, first-out ordering, disabling the prerequisite clock while
> the device is still considered active. Should pm_runtime_force_suspend() be
> called prior to disabling the eee_clk?

Sure, I will reorder it.