[PATCH v3 06/12] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Improve error handling in power_on
Konrad Dybcio
konrad.dybcio at oss.qualcomm.com
Tue Sep 1 06:17:52 PDT 2026
On 8/25/26 2:37 PM, George Moussalem via B4 Relay wrote:
> From: George Moussalem <george.moussalem at outlook.com>
>
> When the PHY fails the enable clocks, it leaves the PHY out of reset.
> Fix this by asserting the reset before returning the error.
>
> In addition, language correct the error messages.
>
> Signed-off-by: George Moussalem <george.moussalem at outlook.com>
> ---
[...]
> ret = clk_bulk_prepare_enable(phy->num_clks, phy->clks);
> if (ret) {
> - dev_err(phy->dev, "clk prepare and enable failed %d\n", ret);
> - return ret;
> + dev_err(phy->dev, "failed to enable clocks: %d\n", ret);
> + goto err_assert_resets;
This is a single-use goto for a single line, just inline it here
Konrad
More information about the linux-phy
mailing list