[PATCH v4 0/6] Fix SATA support for NSP SoCs
Florian Fainelli
florian.fainelli at broadcom.com
Thu Oct 29 14:25:07 PDT 2026
This patch series fixes SATA on the Northstar Plus (BCM58xxx/8831x)
which was broken due to a number of things:
- the SATA PHY assumed separate PCB windows when a shared one is used
for this generation of SoCs
- the clock/reset (IDM) was not being configured by the driver which
meant that depending upon what the boot loader did, or did not, we
could have had the AHCI controller still in reset by then
- on some reference boards, the AHCI controller is not DMA coherent,
assuming so leads to all sorts of timeouts, data corruption, etc.
Since this touches several subsystems: DT, PHY, AHCI and DTS, I would be
keen on having Damien merge all of those via his tree if acceptable by
the DT and PHY maintainers, I am OK either way for Broadcom SoC.
Thanks!
Changes in v4:
- move entire allOf to the bottom, before "unevaluatedProperties" per
Krzysztof's feedback
Changes in v3:
- actually submit the addressed feedback
Changes in v2:
- addressed Damien's comment: comment line too long, imbalanced IDM call
sequence in suspend/resume compared to probe
Florian Fainelli (6):
phy: broadcom: brcm-sata: Keep NSP ports in the shared PCB window
dt-bindings: ata: sata-brcm: Describe the NSP IDM registers
ata: ahci_brcm: Initialize the NSP interface clock and reset
ARM: dts: broadcom: Add the NSP SATA IDM registers
ARM: dts: broadcom: Use noncoherent SATA DMA on BCM958625HR
ARM: dts: broadcom: Enable SATA on BCM958625HR
.../bindings/ata/brcm,sata-brcm.yaml | 57 ++++++++++++-------
arch/arm/boot/dts/broadcom/bcm-nsp.dtsi | 7 ++-
arch/arm/boot/dts/broadcom/bcm958625hr.dts | 5 ++
drivers/ata/ahci_brcm.c | 36 ++++++++++++
drivers/phy/broadcom/phy-brcm-sata.c | 5 +-
5 files changed, 85 insertions(+), 25 deletions(-)
--
2.53.0
More information about the linux-phy
mailing list