[PATCH 2/3] dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock

[sashiko-bot at kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: fallback incompatibility for qcom,nord-snps-eusb2-phy
--

commit fde27e15de912af2a37a383a23a0f964bc729bf2
Author: Shawn Guo <shengchao.guo at oss.qualcomm.com>

dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock

This patch allows an optional second bus clock for the AHB2PHY bridge.
It requires this clock specifically for qcom,nord-snps-eusb2-phy, while
keeping other compatibles limited to the single ref clock.

> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
> index 931cd0e7d297e..67f2a587e65cc 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml

[ ... ]

> @@ -77,6 +81,24 @@ allOf:
>        required:
>          - resets
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: qcom,nord-snps-eusb2-phy
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 2
> +        clock-names:
> +          minItems: 2
[Severity: Medium]
Since Nord requires an additional bus clock for register access, is it
truly backward compatible with the sm8550 fallback?

Currently, properties:compatible requires Nord to use the sm8550 fallback:

properties:
  compatible:
    oneOf:
      - items:
          - enum:
              - qcom,nord-snps-eusb2-phy
              ...
          - const: qcom,sm8550-snps-eusb2-phy

If an older kernel uses the fallback driver to probe the Nord hardware, it
will only enable the ref clock. This will leave the AHB2PHY bridge clock
disabled, leading to register access timeouts (-110) during probe.

Should qcom,nord-snps-eusb2-phy be removed from the sm8550 fallback list
since it cannot be safely driven by the sm8550 driver?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008015017.3359804-1-shengchao.guo@oss.qualcomm.com?part=2