[PATCH v6 3/3] phy: nuvoton: phy-ma35d1-usb2: extend to dual-port with OTG support
Joey Lu
a0987203069 at gmail.com
Tue Oct 6 03:43:04 PDT 2026
Vinod Koul 於 2026/10/6 下午 06:39 寫道:
> On 06-10-26, 18:22, Joey Lu wrote:
>> Vinod Koul 於 2026/10/6 下午 04:37 寫道:
>>> On 06-10-26, 09:37, Joey Lu wrote:
>>>> Vinod Koul 於 2026/10/5 下午 06:07 寫道:
>>>>>> */
>>>>>> #include <linux/bitfield.h>
>>>>>> #include <linux/clk.h>
>>>>>> #include <linux/delay.h>
>>>>>> -#include <linux/io.h>
>>>>> why is this dropped?
>>>> This driver never did direct MMIO access (no readl()/writel()/ioremap()/
>>>> __iomem), even before this series - all register access goes through
>>>> regmap via syscon_regmap_lookup_by_phandle(). So linux/io.h was an
>>>> unused include already, and it's dropped here as part of the broader
>>>> rewrite touching this include block. Happy to keep it if you'd prefer
>>>> not to bundle unrelated include cleanup into this series.
>>> Then it should be a different patch explaining this
>> Understood. I'll drop this change from the series. I'll leave the include
>> unchanged.
> Nope, pls add it, but a separate patch. This in unrelated to this one,
> and should be added but as a different patch.
Got it. I'll add it as a separate patch. Thanks.
More information about the linux-phy
mailing list