[PATCH phy-next 08/13] phy: lynx-28g: make lynx_28g_pll_read_configuration() callable per PLL
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Thu May 28 10:46:16 PDT 2026
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the commit message claiming a change to `lynx_28g_lane_read_configuration()` instead of `lynx_28g_pll_read_configuration()`.
--
commit 8204acc04881cb85ce412b9cf76131f9c69904c5
Author: Vladimir Oltean <vladimir.oltean at nxp.com>
phy: lynx-28g: make lynx_28g_pll_read_configuration() callable per PLL
This commit modifies the lynx_28g_pll_read_configuration function so that
it processes a single PLL structure rather than iterating over all PLLs
internally. The loop iterating over the PLLs is moved to the call site in
lynx_28g_probe.
> There is no functional reason, but lynx_28g_lane_read_configuration() is
> called per lane and lynx_28g_pll_read_configuration() iterates over PLLs
> internally. So the API exported by the lynx_info structure would not be
> uniform. Change lynx_28g_lane_read_configuration() to also permit
> reading the PLL configuration individually, and move the for loop at the
> call site.
[Severity: Low]
This isn't a bug, but there appears to be a typo in the commit message.
It mentions changing lynx_28g_lane_read_configuration to permit reading
the PLL configuration individually, but the patch actually modifies
lynx_28g_pll_read_configuration.
Could the commit message be updated to reflect the correct function name?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260528172404.733196-1-vladimir.oltean@nxp.com?part=8
More information about the linux-phy
mailing list