[PATCH v2 5/5] arm64: dts: qcom: Add Shikra EVK boards

[Komal Bajaj]

On 5/19/2026 6:07 PM, sashiko-bot at kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] shikra-cqs-evk.dts incorrectly includes the modem-enabled SoM dtsi file (shikra-cqm-som.dtsi) instead of its corresponding CQS dtsi file.
> --
>
> commit f25002d6be7ef75f4f5e2dd5f32e45a22f06fc01
> Author: Komal Bajaj <komal.bajaj at oss.qualcomm.com>
>
> arm64: dts: qcom: Add Shikra EVK boards
>
> This commit adds device trees for the Shikra EVK platform, combining different
> Shikra SoM variants with a common carrier board. It introduces three specific
> EVK board configurations: CQM (with modem), CQS (no modem), and IQS (no
> modem), along with a shared common include file.
>
>> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
>> new file mode 100644
>> index 0000000000000..ee460d8c6a877
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
>> @@ -0,0 +1,61 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "shikra-cqm-som.dtsi"
> The commit message states that shikra-cqs-evk.dts pairs with the CQ2390S SoM
> which has no modem support. Does this incorrectly include the modem-enabled
> SoM file instead of its corresponding CQS dtsi file?
>
> Inheriting the hardware description of the CQM board might lead to incorrect
> behavior, such as wasted reserved-memory allocations, or potential probe
> failures when the kernel attempts to initialize the non-existent modem.

  #include "shikra-cqm-som.dtsi" is intentional and correct. CQ2390S SoM 
shares the same PMIC configuration and the same reserved-memory layout 
as the CQM variant because the modem processor would still brought up on 
the CQS to run auxiliary services, it just lacks the RF/modem-peripheral 
hardware.

Thanks
Komal

>
>> +#include "shikra-evk.dtsi"
>> +
>> +/ {
>> +	model = "Qualcomm Technologies, Inc. Shikra CQS EVK";
>> +	compatible = "qcom,shikra-cqs-evk", "qcom,shikra-cqs-som", "qcom,shikra";
> [ ... ]
>