[PATCH v4 1/2] dt-bindings: phy: qcom-edp: Add reference clock for sa8775p eDP PHY
Ritesh Kumar
quic_riteshk at quicinc.com
Wed Mar 11 06:07:31 PDT 2026
On 3/5/2026 12:27 AM, Bjorn Andersson wrote:
> On Wed, Jan 28, 2026 at 05:18:49PM +0530, Ritesh Kumar wrote:
> > The initial sa8775p eDP PHY binding contribution missed adding support for
> > voting on the eDP reference clock. This went unnoticed because the UFS PHY
> > driver happened to enable the same clock.
> >
> > After commit 77d2fa54a945 ("scsi: ufs: qcom : Refactor phy_power_on/off
> > calls"), the eDP reference clock is no longer kept enabled, which results
> > in the following PHY power-on failure:
> >
> > phy phy-aec2a00.phy.10: phy poweron failed --> -110
> >
> > To fix this, explicit voting for the eDP reference clock is required.
> > This patch adds the eDP reference clock for sa8775p eDP PHY and updates
> > the corresponding example node.
> >
> > Signed-off-by: Ritesh Kumar <quic_riteshk at quicinc.com>
>
> Is there any reason why you didn't follow up on this patch Ritesh?
> Looks like it's ready to be merged.
I was waiting for patch to merge as there is no pending comments.
> Reviewed-by: Bjorn Andersson <andersson at kernel.org>
>
> Regards,
> Bjorn
>
> > ---
> > .../devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 6 ++++--
> > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 +
> > 2 files changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> > index e2730a2f25cf..6c827cf9692b 100644
> > --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> > @@ -200,9 +200,11 @@ examples:
> > <0x0aec2000 0x1c8>;
> >
> > clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
> > - <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>;
> > + <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
> > + <&gcc GCC_EDP_REF_CLKREF_EN>;
> > clock-names = "aux",
> > - "cfg_ahb";
> > + "cfg_ahb",
> > + "ref";
> >
> > #clock-cells = <1>;
> > #phy-cells = <0>;
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > index 4a1daae3d8d4..0bf8bf4f66ac 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> > @@ -74,6 +74,7 @@ allOf:
> > compatible:
> > enum:
> > - qcom,glymur-dp-phy
> > + - qcom,sa8775p-edp-phy
> > - qcom,x1e80100-dp-phy
> > then:
> > properties:
> > --
> > 2.34.1
> >
More information about the linux-phy
mailing list