[PATCH v13 5/5] dt-bindings: media: qcom,x1e80100-camss: Make vdd-csiphy supplies optional

[sashiko-bot at kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete schema update for split PHY topology causes dt_binding_check failures and incorrect hardware descriptions.
--

--- Patch [5]: [PATCH v13 5/5] dt-bindings: media: qcom,x1e80100-camss: Make vdd-csiphy supplies optional ---
commit 8ca017ccca6ab80da696ef7ec19b3fc7494d6187
Author: Bryan O'Donoghue <bryan.odonoghue at linaro.org>

dt-bindings: media: qcom,x1e80100-camss: Make vdd-csiphy supplies optional

This commit removes the vdd-csiphy-0p8-supply and vdd-csiphy-1p2-supply from
the required list in the qcom,x1e80100-camss binding. This makes the supplies
optional to support moving the csiphy to peer nodes while maintaining
backwards compatibility.

> diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> index 126400772d028..57a838fe2d229 100644
> --- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> @@ -186,8 +186,6 @@ required:
>    - iommus
>    - power-domains
>    - power-domain-names
> -  - vdd-csiphy-0p8-supply
> -  - vdd-csiphy-1p2-supply

[Severity: Medium]
Since the CSIPHY nodes are being moved out to peer nodes, do other properties
in this schema also need to be updated to prevent validation regressions?

For example, the reg-names, clock-names, and interrupt-names in this schema
are currently defined as strict, fixed-order arrays that expect csiphy elements
at specific indices. If those elements are removed from the CAMSS node to avoid
resource conflicts, won't the remaining elements shift and cause
dt_binding_check to fail?

Additionally, the ports schema mandates data-lanes on the CAMSS endpoints.
Is this requirement still correct for internal links between the CAMSS core
and a peer PHY, rather than physical lanes to the sensor?

>    - ports
>  
>  additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v13-0-ae811e2f0799@linaro.org?part=5