[PATCH v3 2/2] phy: qcom: qmp-combo: Add SM8475 support

[sashiko-bot at kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `sm8475_usb3dpphy_cfg` structure is missing the `.calibrate_dp_phy` callback assignment, which is required for robust DisplayPort link training.
--

--- Patch [2]: [PATCH v3 2/2] phy: qcom: qmp-combo: Add SM8475 support ---
commit d1b4bfb2d91dc0cdfa3d2edd1cdd59ff8122136f
Author: Esteban Urrutia <esteuwu at proton.me>

phy: qcom: qmp-combo: Add SM8475 support

This commit adds USB/DP combo PHY support for the SM8475 SoC, introducing
specific RX and PCS USB tables while reusing existing serdes, TX, and PCS
tables. It also adds v1 PLL structures to address link training issues caused
by reference clock differences on 4nm-v1 PLLs.

> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> index cdcfad2e86b1d..52b07de2c52b5 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c

[ ... ]

> @@ -2845,6 +2965,51 @@ static const struct qmp_phy_cfg sm8350_usb3dpphy_cfg = {
>  	.has_pwrdn_delay	= true,
>  };
>  
> +static const struct qmp_phy_cfg sm8475_usb3dpphy_cfg = {
> +	.offsets		= &qmp_combo_offsets_v3,

[ ... ]

> +	.dp_aux_init		= qmp_v4_dp_aux_init,
> +	.configure_dp_tx	= qmp_v4_configure_dp_tx,
> +	.configure_dp_clocks	= qmp_v3_configure_dp_clocks,
> +	.configure_dp_phy	= qmp_v4_configure_dp_phy,
> +
> +	.regs			= qmp_v6_usb3phy_regs_layout,

[Severity: Medium]
Is the .calibrate_dp_phy callback missing here?

Other v6 DP PHY configurations (like sm8550 and sar2130p) assign this to
qmp_v4_calibrate_dp_phy. Without the calibration callback, calls to
phy_calibrate() from the DRM driver return 0 without actually adjusting the
DP AUX tuning parameters (QSERDES_DP_PHY_AUX_CFG1).

Can this cause DP Alt Mode link training to fail on stricter sink devices or
with marginal cables that require alternative AUX calibration values?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722-sm8475-bup-usbss-v3-0-0dd5da218ab2@proton.me?part=2