[PATCH] phy: qcom-qmp: qserdes-com: drop duplicate v8 DP headers
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Wed Jul 22 03:42:59 PDT 2026
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately claims to revert commit d10736db98d2, but only a single unused header file is removed while the rest of the commit's substantial changes are left intact.
--
--- Patch [1]: [PATCH] phy: qcom-qmp: qserdes-com: drop duplicate v8 DP headers ---
commit 446ffedaada35b4903cda4c10742fca69498a002
Author: Dmitry Baryshkov <dmitry.baryshkov at oss.qualcomm.com>
phy: qcom-qmp: qserdes-com: drop duplicate v8 DP headers
This commit removes a duplicate header file for V8 DisplayPort QSERDES COM
registers. It states that it reverts a previous commit that introduced the
duplicate header alongside Glymur platform settings.
> Commit 212cdedcac11 ("phy: qcom-qmp: qserdes-com: Add v8
> DP-specific qserdes register offsets") and commit d10736db98d2 ("phy:
> qualcomm: qmp-combo: Add DP offsets and settings for Glymur platforms")
> added identical header files for DisplayPort-specific registers on V8
> PHYs, having different names. Get rid of one of the copies, reverting
> commit d10736db98d2 ("phy: qualcomm: qmp-combo: Add DP offsets and
> settings for Glymur platforms")
[Severity: Medium]
Is this commit message accurate?
It states this commit is reverting d10736db98d2 entirely, but the diff
only removes the duplicate header file. The Glymur platform settings and
tables (such as qmp_v8_dp_serdes_tbl in
drivers/phy/qualcomm/phy-qcom-qmp-combo.c) introduced by that commit are
left intact.
Would it be more precise to rephrase this so it doesn't suggest a full
revert?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260722-qmp-drop-duplicate-v8-v1-1-795eb7de0322@oss.qualcomm.com?part=1
More information about the linux-phy
mailing list