[PATCH 1/2] dt-bindings: phy: Document MT8196 MediaTek PCI-Express Gen4 S-PHY
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Thu Jul 16 08:21:55 PDT 2026
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing upper bound (`maxItems`) for the `reg` property array.
--
--- Patch [1]: [PATCH 1/2] dt-bindings: phy: Document MT8196 MediaTek PCI-Express Gen4 S-PHY ---
commit 46cb0bc5744a1aaeece570f9d383cc948bbcab79
Author: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
dt-bindings: phy: Document MT8196 MediaTek PCI-Express Gen4 S-PHY
This commit introduces the device tree binding documentation for the
PCI-Express Gen4 S-PHY found in newer MediaTek SoCs like the MT8196. It
details the required properties, nvmem cells, and power domains for this
hardware.
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,mt8196-pcie-sphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,mt8196-pcie-sphy.yaml
> new file mode 100644
> index 0000000000000..2b61882c402c2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/mediatek,mt8196-pcie-sphy.yaml
[ ... ]
> +properties:
> + compatible:
> + const: mediatek,mt8196-pcie-sphy
> +
> + reg:
> + minItems: 2
> +
> + reg-names:
> + items:
> + - const: sif
> + - const: ckm
[Severity: Low]
Is an upper bound missing for the reg property array here?
The schema defines minItems: 2 but omits maxItems. Since reg-names explicitly
defines exactly two items, should reg include maxItems: 2 as well to fully
bound the array and prevent potential dt_binding_check validation warnings?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260716151333.77254-1-angelogioacchino.delregno@collabora.com?part=1
More information about the linux-phy
mailing list