[PATCH v3] phy: rockchip: naneng-combphy: Consolidate SSC configuration

[Alexey Charkov]

On Tue, Jul 14, 2026 at 5:42 PM Vinod Koul <vkoul at kernel.org> wrote:
>
> On 14-07-26, 16:58, Alexey Charkov wrote:
> > On Tue, May 19, 2026 at 2:48 PM Vinod Koul <vkoul at kernel.org> wrote:
> > >
> > >
> > > On Mon, 27 Apr 2026 08:57:13 +0800, Shawn Lin wrote:
> > > > The PCIe SSC configuration for the RK3588 and RK3576 SoCs required
> > > > additional tuning which is missing. When adding these same SSC
> > > > configurations for both of these two SoCs, as well as upcoming
> > > > platforms, it's obvious the SSC setup code was largely duplicated
> > > > across the platform-specific configuration functions. This becomes
> > > > harder to maintain as more platforms are added.
> > > >
> > > > [...]
> > >
> > > Applied, thanks!
> > >
> > > [1/1] phy: rockchip: naneng-combphy: Consolidate SSC configuration
> > >       commit: 0b31f297557fff0941769e8257198151a0fbe8bf
> >
> > This commit breaks USB3 operation on RK3576 (at least in host mode),
> > causing an endless flood of messages like this every second in dmesg:
> >
> > usb usb2-port1: Cannot enable. Maybe the USB cable is bad?
> >
> > USB 2.0 part enumerates, but USB 3.0 doesn't. Tested on two different
> > devices having a CoreChips SL6341 USB 2.0/USB 3.0 hub onboard
> > connected to &usb_drd1_dwc3, bisected to this commit.
> >
> > Has this been reported yet, or shall I investigate further which part
> > of the patch causes the breakage?
>
> First I heard, would be good to investigate.
> I can revert if we dont find a fix soon...

Thanks for confirming Vinod. I've preliminarily identified the SSC
direction setting as the culprit: before the refactor it was
unconditionally set to downward, after the refactor it's only set when
(priv->enable_ssc), which is not the case for USB3 on RK3576 (haven't
checked the others).

Will double check everything and send a fix (it's just moving the
priv->enable_ssc check 10 lines down, before enabling SSC but after
setting the direction).

Best regards,
Alexey