[PATCH v3] phy: rockchip: naneng-combphy: Consolidate SSC configuration

[Alexey Charkov]

On Tue, May 19, 2026 at 2:48 PM Vinod Koul <vkoul at kernel.org> wrote:
>
>
> On Mon, 27 Apr 2026 08:57:13 +0800, Shawn Lin wrote:
> > The PCIe SSC configuration for the RK3588 and RK3576 SoCs required
> > additional tuning which is missing. When adding these same SSC
> > configurations for both of these two SoCs, as well as upcoming
> > platforms, it's obvious the SSC setup code was largely duplicated
> > across the platform-specific configuration functions. This becomes
> > harder to maintain as more platforms are added.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] phy: rockchip: naneng-combphy: Consolidate SSC configuration
>       commit: 0b31f297557fff0941769e8257198151a0fbe8bf

This commit breaks USB3 operation on RK3576 (at least in host mode),
causing an endless flood of messages like this every second in dmesg:

usb usb2-port1: Cannot enable. Maybe the USB cable is bad?

USB 2.0 part enumerates, but USB 3.0 doesn't. Tested on two different
devices having a CoreChips SL6341 USB 2.0/USB 3.0 hub onboard
connected to &usb_drd1_dwc3, bisected to this commit.

Has this been reported yet, or shall I investigate further which part
of the patch causes the breakage?

Best regards,
Alexey
---
0b31f297557fff0941769e8257198151a0fbe8bf is the first bad commit
commit 0b31f297557fff0941769e8257198151a0fbe8bf
Author: Shawn Lin <shawn.lin at rock-chips.com>
Date:   Mon Apr 27 08:57:13 2026 +0800

    phy: rockchip: naneng-combphy: Consolidate SSC configuration

    The PCIe SSC configuration for the RK3588 and RK3576 SoCs required
    additional tuning which is missing. When adding these same SSC
    configurations for both of these two SoCs, as well as upcoming
    platforms, it's obvious the SSC setup code was largely duplicated
    across the platform-specific configuration functions. This becomes
    harder to maintain as more platforms are added.

    So extract the common SSC logic into a shared helper function,
    rk_combphy_common_cfg_ssc(). This cleans up the per-platform drivers
    and centralizes the standard configuration as possible.

    Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>
    Reviewed-by: Heiko Stuebner <heiko at sntech.de>
    Signed-off-by: Shawn Lin <shawn.lin at rock-chips.com>
    Link: https://patch.msgid.link/1777251433-110466-1-git-send-email-shawn.lin@rock-chips.com
    Signed-off-by: Vinod Koul <vkoul at kernel.org>

 drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 173
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------------------------
 1 file changed, 73 insertions(+), 100 deletions(-)