[PATCH v8 1/2] dt-bindings: phy: eswin: Document the EIC7700 SoC SATA PHY

[Krzysztof Kozlowski]

On Fri, Jan 23, 2026 at 10:49:36AM +0800, Yulin Lu wrote:
> +  eswin,tx-amplitude-tuning:
> +    description: This adjusts the transmitter amplitude signal, and its value
> +      is derived from eye diagram tuning. The three values correspond to Gen1,
> +      Gen2, and Gen3 parameters respectively.
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    items:
> +      - description: Gen1 parameter.
> +        minimum: 0
> +        maximum: 0x7f
> +        default: 0
> +      - description: Gen2 parameter.
> +        minimum: 0
> +        maximum: 0x7f
> +        default: 0
> +      - description: Gen3 parameter.
> +        minimum: 0
> +        maximum: 0x7f
> +        default: 0

I think defaults should be specified like this:
https://elixir.bootlin.com/linux/v6.19-rc5/source/Documentation/devicetree/bindings/sound/adi,adau7118.yaml#L54

> +
> +  eswin,tx-preemph-tuning:
> +    description: This adjusts the transmitter de-emphasis signal, and its value
> +      is derived from eye diagram tuning. The three values correspond to Gen1,
> +      Gen2, and Gen3 parameters respectively.
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    items:
> +      - description: Gen1 parameter.
> +        minimum: 0
> +        maximum: 0x3f
> +        default: 0
> +      - description: Gen2 parameter.
> +        minimum: 0
> +        maximum: 0x3f
> +        default: 0
> +      - description: Gen3 parameter.
> +        minimum: 0
> +        maximum: 0x3f
> +        default: 0

Same here

Best regards,
Krzysztof