[PATCH RFC/DO NOT MERGE 08/12] drm/msm/hdmi: Add support for PM OPP table
Krzysztof Kozlowski
krzk at kernel.org
Mon Aug 31 22:58:41 PDT 2026
On 31/08/2026 18:43, Konrad Dybcio wrote:
> On 8/28/26 4:05 PM, Krzysztof Kozlowski wrote:
>> Allow scaling the domain rails with PM OPP, which uses the pixclock
>> ("extp"). This allows proper votes depending on requested HDMI pixel
>> rate.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at oss.qualcomm.com>
>> ---
>
> [...]
>
>> - if (hdmi->extp_clk)
>> + if (hdmi->extp_clk) {
>> clk_disable_unprepare(hdmi->extp_clk);
>> + dev_pm_opp_set_rate(&hdmi->pdev->dev, 0);
>
> FWIW rescinding the vote will happen automatically as the device runtime
> suspends. If you think this is necessary, let's do
>
> dev_pm_opp_set_opp(dev, NULL);
>
> instead, since dev_pm_opp_set_rate(0) is a ""dark pattern"" that is
> usually misused, see e.g.:
>
> https://lore.kernel.org/linux-arm-msm/20260728-topic-dpu_power-v1-0-e7783b859a70@oss.qualcomm.com/
Ack
Best regards,
Krzysztof
More information about the linux-phy
mailing list