[PATCH 7/7] dt-bindings: usb: ti,da830-musb: Convert to DT schema
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Mon Aug 17 15:01:16 PDT 2026
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `dma-names` property lacks the string pattern constraint defined in the original text binding.
--
--- Patch [7]: [PATCH 7/7] dt-bindings: usb: ti,da830-musb: Convert to DT schema ---
commit 39394a808ae75fe269a96ac3b8ee7106aa98c9ea
Author: Bhargav Joshi <j.bhargav.u at gmail.com>
dt-bindings: usb: ti,da830-musb: Convert to DT schema
This commit converts the TI DA8xx/OMAP-L1x MUSB text bindings to device tree
schema format. It also adds required address and size cells properties since
the DA8xx MUSB node acts as a parent bus for the CPPI41 DMA controller.
> diff --git a/Documentation/devicetree/bindings/usb/ti,da830-musb.yaml b/Documentation/devicetree/bindings/usb/ti,da830-musb.yaml
> new file mode 100644
> index 0000000000000..c54bdfb4d1ad9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,da830-musb.yaml
[ ... ]
> + dmas:
> + minItems: 1
> + maxItems: 8
> +
> + dma-names:
> + minItems: 1
> + maxItems: 8
[Severity: Low]
Does this code drop the naming constraint defined in the original text binding?
The previous text document specified: "Use rxN for receive and txN for
transmit endpoints. N specifies the endpoint number."
This definition lacks an items section with a pattern constraint (such as
pattern: "^(rx|tx)[1-4]$") to enforce the expected endpoint naming. Without
this constraint, the schema will allow invalid device trees with arbitrary
dma-names to silently pass validation.
> +
> + vbus-supply:
> + description: Phandle to a regulator providing the USB bus power.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260818-ti-am33-usb-v1-0-69ac5f92df45@gmail.com?part=7
More information about the linux-phy
mailing list