[PATCH 2/2] dt-bindings: phy: ti,phy-usb3: document aspcie reference clock setting
Krzysztof Kozlowski
krzk at kernel.org
Wed Aug 5 00:39:04 PDT 2026
On Tue, Aug 04, 2026 at 01:18:49PM +0200, David Oberhollenzer wrote:
> Add syscon-acspcie-tx-rx property to the PHY bindings.
Why? Actually better to explain WHY in the property description.
>
> Signed-off-by: David Oberhollenzer <david.oberhollenzer at sigma-star.at>
> ---
> Documentation/devicetree/bindings/phy/ti,phy-usb3.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/ti,phy-usb3.yaml b/Documentation/devicetree/bindings/phy/ti,phy-usb3.yaml
> index 84f538aa587c..4fb017df2898 100644
> --- a/Documentation/devicetree/bindings/phy/ti,phy-usb3.yaml
> +++ b/Documentation/devicetree/bindings/phy/ti,phy-usb3.yaml
> @@ -52,6 +52,15 @@ properties:
> enum: [wkupclk, sysclk, refclk, dpll_ref,
> dpll_ref_m2, phy-div, div-clk]
>
> + syscon-acspcie-tx-rx:
Please organize the patch documenting the compatible (DT bindings)
before the patch using that compatible.
See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
Not a valid naming, missing vendor prefix and syscon looks like
Linuxism, since you called it "system control module".
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + maxItems: 1
> + items:
> + items:
Missing -
Also, update the example.
Best regards,
Krzysztof
More information about the linux-phy
mailing list