[PATCH v2 02/10] dt-bindings: phy: rockchip: naneng-combphy: add rockchip,sgmii-mac-sel property

[sashiko-bot at kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `rockchip,sgmii-mac-sel` property is defined in the device tree bindings but is not implemented in any kernel driver.
--

--- Patch [2]: [PATCH v2 02/10] dt-bindings: phy: rockchip: naneng-combphy: add rockchip,sgmii-mac-sel property ---
commit d067678ae28ccb1e1d1f20a8cb8013f22a387abc
Author: Coia Prant <coiaprant at gmail.com>

dt-bindings: phy: rockchip: naneng-combphy: add rockchip,sgmii-mac-sel property

This commit adds the optional rockchip,sgmii-mac-sel property to the Rockchip
Naneng combphy device tree binding. The property is intended to allow routing
the SGMII interface to either GMAC0 or GMAC1 via GRF registers.

> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
[ ... ]
> @@ -80,6 +80,15 @@ properties:
>      description:
>        Some additional pipe settings are accessed through GRF regs.
>  
> +  rockchip,sgmii-mac-sel:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [0, 1]

[Severity: Medium]
Is the driver implementation for this property missing from the series?

The device tree binding defines rockchip,sgmii-mac-sel, but it appears
no kernel driver currently parses this property or writes the corresponding
configuration to the GRF registers.

Without driver support, boards relying on this property to configure the MAC
will fail to route SGMII to GMAC0, leaving it at the default GMAC1.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260801142244.679437-2-coiaprant@gmail.com?part=2