[PATCH v2 02/22] usb: dwc3: dwc3_power_off_all_roothub_ports: Use ioremap_np when required

[Thinh Nguyen]

On Sat, Sep 06, 2025, Sven Peter wrote:
> On Apple Silicon machines we can't use ioremap() / Device-nGnRE to map most
> regions but must use ioremap_np() / Device-nGnRnE whenever
> IORESOURCE_MEM_NONPOSTED is set. Make sure this is also done inside
> dwc3_power_off_all_roothub_ports to prevent SErrors.
> 
> Fixes: 2d2a3349521d ("usb: dwc3: Add workaround for host mode VBUS glitch when boot")
> Cc: stable at kernel.org
> Signed-off-by: Sven Peter <sven at kernel.org>
> ---
>  drivers/usb/dwc3/host.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index 1c513bf8002ec9ec91b41bfd096cbd0da1dd2d2e..e77fd86d09cf0a36161c20ad3c83f10e67099775 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -37,7 +37,10 @@ static void dwc3_power_off_all_roothub_ports(struct dwc3 *dwc)
>  
>  	/* xhci regs are not mapped yet, do it temporarily here */
>  	if (dwc->xhci_resources[0].start) {
> -		xhci_regs = ioremap(dwc->xhci_resources[0].start, DWC3_XHCI_REGS_END);
> +		if (dwc->xhci_resources[0].flags & IORESOURCE_MEM_NONPOSTED)
> +			xhci_regs = ioremap_np(dwc->xhci_resources[0].start, DWC3_XHCI_REGS_END);
> +		else
> +			xhci_regs = ioremap(dwc->xhci_resources[0].start, DWC3_XHCI_REGS_END);
>  		if (!xhci_regs) {
>  			dev_err(dwc->dev, "Failed to ioremap xhci_regs\n");
>  			return;
> 
> -- 
> 2.34.1
> 
> 

Acked-by: Thinh Nguyen <Thinh.Nguyen at synopsys.com>

Thanks,
Thinh