[PATCH v3 3/7] dt-bindings: phy: rockchip-inno-csi-dphy: add rk3588 variant

Krzysztof Kozlowski krzk at kernel.org
Tue Sep 2 00:55:47 PDT 2025


On Mon, Sep 01, 2025 at 10:47:44PM +0200, Michael Riesch wrote:
> The Rockchip RK3588 variant of the CSI-2 DPHY features two reset lines.
> Add the variant and allow for the additional reset.
> 
> Signed-off-by: Michael Riesch <michael.riesch at collabora.com>
> ---
>  .../bindings/phy/rockchip-inno-csi-dphy.yaml       | 50 +++++++++++++++++++++-
>  1 file changed, 49 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml
> index 9ad72518e6da..e37c9fd74788 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml
> @@ -21,6 +21,7 @@ properties:
>        - rockchip,rk3326-csi-dphy
>        - rockchip,rk3368-csi-dphy
>        - rockchip,rk3568-csi-dphy
> +      - rockchip,rk3588-csi-dphy
>  
>    reg:
>      maxItems: 1
> @@ -40,11 +41,15 @@ properties:
>  
>    resets:
>      items:
> -      - description: exclusive PHY reset line
> +      - description: APB reset line
> +      - description: PHY reset line

That's changing the order, before first was the phy....

> +    minItems: 1
>  
>    reset-names:
>      items:
>        - const: apb
> +      - const: phy

Although here first was apb? Quite confusing.

Anyway "phy" reset for "phy" is pretty non-informative, please give some
useful name.

> +    minItems: 1

Best regards,
Krzysztof




More information about the linux-phy mailing list