[PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible

[Krzysztof Kozlowski]

On 08/10/2025 13:45, Pritam Manohar Sutar wrote:
> Hi Krzysztof,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk at kernel.org>
>> Sent: 07 October 2025 11:54 AM
>> To: Pritam Manohar Sutar <pritam.sutar at samsung.com>; vkoul at kernel.org;
>> kishon at kernel.org; robh at kernel.org; krzk+dt at kernel.org;
>> conor+dt at kernel.org; alim.akhtar at samsung.com; andre.draszik at linaro.org;
>> peter.griffin at linaro.org; kauschluss at disroot.org;
>> ivo.ivanov.ivanov1 at gmail.com; igor.belwon at mentallysanemainliners.org;
>> m.szyprowski at samsung.com; s.nawrocki at samsung.com
>> Cc: linux-phy at lists.infradead.org; devicetree at vger.kernel.org; linux-
>> kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-samsung-
>> soc at vger.kernel.org; rosa.pila at samsung.com; dev.tailor at samsung.com;
>> faraz.ata at samsung.com; muhammed.ali at samsung.com;
>> selvarasu.g at samsung.com
>> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
>> ExynosAutov920 HS phy compatible
>>
>> On 22/09/2025 14:26, Pritam Manohar Sutar wrote:
>>> This phy needs 0.75v, 0.18v and 3.3v supplies for its internal
>>> functionally. Power Supply's names are as per phy's User Data-Book.
>>> These names, (dvdd, vdd18 and vdd33), are considered  for 0.75v, 1.8v
>>> and 3.3v respectively.
>>> "
>>>
>>>>
>>>> I still cannot find constraints for the rest of properties, though.
>>>
>>> Sorry I didn't get it completely. Can you please elaborate on the same?
>>
>>
>> Writing bindings and introductory talks elaborate on that. You add properties
>> without constraints. That's not what we want. We want constraints.
>>
> 
> Have added only supplies in this patch-set. However, was going 
> through schema example and it says nothing is needed to define
> in terms of supply. 


I don't have original patchset in my inbox anymore, so not sure what was
there, but most likely you miss constraining the presence of these
properties per each variant. IOW, not each of devices in the bindings
have these supplies, so I expect syntax similar as in example-schema.

https://elixir.bootlin.com/linux/v5.19/source/Documentation/devicetree/bindings/example-schema.yaml#L212


Best regards,
Krzysztof