[PATCH v3 2/2] arm64: dts: qcom: sa8775p: Remove max link speed property for PCIe EP
Mrinmay Sarkar
mrinmay.sarkar at oss.qualcomm.com
Thu May 29 22:38:04 PDT 2025
On Tue, May 27, 2025 at 4:06 PM Konrad Dybcio
<konrad.dybcio at oss.qualcomm.com> wrote:
>
> On 5/25/25 3:29 PM, Dmitry Baryshkov wrote:
> > On Sun, May 25, 2025 at 11:27:18AM +0530, Mrinmay Sarkar wrote:
> >> From: Mrinmay Sarkar <mrinmay.sarkar at oss.qualcomm.com>
> >>
> >> The maximum link speed was previously restricted to Gen3 due to the
> >> absence of Gen4 equalization support in the driver.
> >>
> >> Add change to remove max link speed property, Since Gen4 equalization
> >> support has already been added into the driver.
> >
> > As Gen4 equalization is already supported by the XYZ driver remove the
> > max-link-speed property.
> >
> > "Add change to remove" is a bit clumsy.
>
> I'm more worried about this node not having these gen4 eq settings
> (i.e. the part talking about driver support landing is true, but it's
> unused without the presets being explicitly defined in eq-presets-16gts)
>
> Konrad
Hi Konrad,
Actually stability issue was resolved by this patch series:
https://lore.kernel.org/linux-pci/20240911-pci-qcom-gen4-stability-v7-3-743f5c1fd027@linaro.org/
and I don't think we need to define eq-presets-16gts for this.
Thanks,
Mrinmay
More information about the linux-phy
mailing list