[bug report] phy: qcom: Add QCOM SNPS eUSB2 driver
Dan Carpenter
dan.carpenter at linaro.org
Fri May 23 08:59:54 PDT 2025
Hello Abel Vesa,
Commit 80090810f5d3 ("phy: qcom: Add QCOM SNPS eUSB2 driver") from
Feb 8, 2023 (linux-next), leads to the following Smatch static
checker warning:
drivers/phy/phy-snps-eusb2.c:571 snps_eusb2_hsphy_probe()
warn: passing zero to 'PTR_ERR'
drivers/phy/phy-snps-eusb2.c
557 ret = devm_clk_bulk_get(dev, phy->data->num_clks, phy->clks);
558 if (ret)
559 return dev_err_probe(dev, ret,
560 "failed to get phy clock(s)\n");
561
562 phy->ref_clk = NULL;
^^^^^^^^^^^^^^^^^^^^
563 for (int i = 0; i < phy->data->num_clks; ++i) {
564 if (!strcmp(phy->clks[i].id, "ref")) {
565 phy->ref_clk = phy->clks[i].clk;
566 break;
567 }
568 }
569
570 if (IS_ERR_OR_NULL(phy->ref_clk))
--> 571 return dev_err_probe(dev, PTR_ERR(phy->ref_clk),
^^^^^^^^^^^^^^^^^^^^^
PTR_ERR(NULL) is success.
572 "failed to get ref clk\n");
573
574 num = ARRAY_SIZE(phy->vregs);
575 for (i = 0; i < num; i++)
regards,
dan carpenter
More information about the linux-phy
mailing list