[PATCH v3 05/12] dt-bindings: phy: renesas,usb2-phy: Add renesas,sysc-signals
Krzysztof Kozlowski
krzk at kernel.org
Thu May 22 00:03:41 PDT 2025
On Wed, May 21, 2025 at 05:09:36PM GMT, Claudiu wrote:
> .../bindings/phy/renesas,usb2-phy.yaml | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> index 12f8d5d8af55..e1e773cba847 100644
> --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> @@ -86,6 +86,16 @@ properties:
>
> dr_mode: true
>
> + renesas,sysc-signals:
> + description: System controller phandle, specifying the register
> + offset and bitmask associated with a specific system controller signal
This is 100% redundant information. system controller specifying system
controller signal.
Drop.
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + - items:
> + - description: system controller phandle
What for? Explain the usage. How is ut used by this hardware.
> + - description: register offset associated with a signal
What signal? That's a phy.
> + - description: register bitmask associated with a signal
> +
> if:
> properties:
> compatible:
> @@ -117,6 +127,18 @@ allOf:
> required:
> - resets
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,usb2-phy-r9a08g045
> + then:
> + required:
> + - renesas,sysc-signals
That's ABI break.
Best regards,
Krzysztof
More information about the linux-phy
mailing list