[PATCH v2 05/13] gpio: max3191x: use gpiod_multi_set_value_cansleep
David Lechner
dlechner at baylibre.com
Fri Feb 7 07:23:11 PST 2025
On 2/7/25 4:34 AM, Andy Shevchenko wrote:
> On Fri, Feb 7, 2025 at 12:48 AM David Lechner <dlechner at baylibre.com> wrote:
>>
>> Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of
>> gpiod_set_array_value_cansleep().
>
> It seems you missed my comment.
Yes, I must have been sleeping on the job. :-/
>
>> +static void gpiod_set_array_single_value_cansleep(struct gpio_descs *descs,
>> int value)
>
> This is not good namespacing. Can we change this while at it?
sure
>
> max3191x_...
>
> (I would go with max3191x_set_modesel_pins() to make it shorter. I
> have no clue why the function repeats so much from gpiod API naming.
> Is there anything else which is named in a similar way? Perhaps fix it
> by a separate patch?)
>
More information about the linux-phy
mailing list