AW: [PATCH v5 2/2] phy: Realtek Otto SerDes driver

[markus.stockhausen at gmx.de]

> Von: Vinod Koul <vkoul at kernel.org>
> Gesendet: Sonntag, 8. Dezember 2024 17:38
> An: Markus Stockhausen <markus.stockhausen at gmx.de>
> Cc: kishon at kernel.org; robh at kernel.org; krzk+dt at kernel.org;
conor+dt at kernel.org; linux-phy at lists.infradead.org;
devicetree at vger.kernel.org; chris.packham at alliedtelesis.co.nz
> Betreff: Re: [PATCH v5 2/2] phy: Realtek Otto SerDes driver
>
> On 17-10-24, 12:24, Markus Stockhausen wrote:
> > The Realtek Otto platform is a series of 4 different MIPS32 based
> > network switch SoCs. They consist of:
> >
> > ....
> > +DEFINE_SHOW_ATTRIBUTE(rtsds_dbg_polarity);
> > +
> > +static void rtsds_dbg_init(struct rtsds_ctrl *ctrl, u32 sid) {
> > +	debugfs_create_file("mode", 0600, ctrl->sds[sid].phy->debugfs,
> > +			    &ctrl->sds[sid].phy->dev, &rtsds_dbg_mode_fops);
> > +
> > +	debugfs_create_file("reset", 0200, ctrl->sds[sid].phy->debugfs,
> > +			    &ctrl->sds[sid].phy->dev,
&rtsds_dbg_reset_fops);
> > +
> > +	debugfs_create_file("polarity", 0400, ctrl->sds[sid].phy->debugfs,
> > +			    &ctrl->sds[sid].phy->dev,
&rtsds_dbg_polarity_fops);
> > +
> > +	debugfs_create_file("registers", 0600, ctrl->sds[sid].phy->debugfs,
> > +			    &ctrl->sds[sid].phy->dev,
&rtsds_dbg_registers_fops); }
>
> Please create a driver directory and add files to that please

Sorry for the late response as I have been busy otherwise. I will take care
about the things you noted. Regarding this advise: Do you want me to create
a separate directory in the debugfs or for the driver source code?

Markus