[EXT] Re: [PATCH v18 3/8] dt-bindings: display: bridge: Add Cadence MHDP8501

[Sandor Yu]

> 
> On 29/10/2024 08:17, Sandor Yu wrote:
> >>
> >> On Tue, Oct 29, 2024 at 02:02:11PM +0800, Sandor Yu wrote:
> >>> +  interrupts:
> >>> +    items:
> >>> +      - description: Hotplug cable plugin.
> >>> +      - description: Hotplug cable plugout.
> >>> +
> >>> +  interrupt-names:
> >>> +    items:
> >>> +      - const: plug_in
> >>> +      - const: plug_out
> >>> +
> >>> +  data-lanes:
> >>> +    $ref:
> /schemas/media/video-interfaces.yaml#/properties/data-lanes
> >>> +    minItems: 4
> >>> +    maxItems: 4
> >>> +    description: Lane reordering for HDMI or DisplayPort interface.
> >>
> >> Please look how existing bindings do it. data-lanes is a property of port.
> >> Otherwise why would you like this to be applied to the input?
> >
> > 'lane reordering' is a feature of the MHDP IP, and different boards have
> different mappings.
> 
> Yeah, and?
> 
> >
> > Benjamin comments in v16, the imx8mq-zii-ultra board's lane mapping
> > differs from the default in my driver, so we need to treat it as an input.
> 
> But HDMI is not your input port. At least that's what few lines below!
> This is confusing.
> 
> >
> > As data-lanes is a property of port, so there is no exist property
> > could be reused,
> 
> data-lanes, really, what is the problem here?
> 
> > How about revert 'data-lanes' back to my previous implementation of
> 'lane-mapping'?
> 
> No.

I believe I understand now. 
The HDMI driver has two ports, and I will move the 'data-lanes' property to the endpoint of output port.

B.R
Sandor