[PATCH v2 5/5] phy: qcom: qmp-usbc: Add qmp configuration for QCS615

[Tingwei Zhang]

On 10/18/2024 4:06 PM, Dmitry Baryshkov wrote:
> On Fri, 18 Oct 2024 at 10:48, Tingwei Zhang <quic_tingweiz at quicinc.com> wrote:
>>
>> On 10/18/2024 2:27 AM, Dmitry Baryshkov wrote:
>>> On Thu, 17 Oct 2024 at 16:07, Krishna Kurapati
>>> <quic_kriskura at quicinc.com> wrote:
>>>>
>>>> Provide PHY configuration for the USB QMP PHY for QCS615 Platform.
>>>>
>>>> Signed-off-by: Krishna Kurapati <quic_kriskura at quicinc.com>
>>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>>>
>>> After checking platform details,
>>>
>>> Unreviewed-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>>>
>>> Please perform global s/QCS615/SM6150/ and s/qcs615/sm6150/
>>
>> QCS615 and SM6150 are different variants of the same SoC. QCS615 is an
>> IoT variant, while SM6150 is a mobile variant. We are currently adding
>> QCS615 SoC support to the upstream Kernel, as it is in an active
>> development stage and we anticipate many products based on this SoC. On
>> the other hand, the SM6150 is an older mobile platform that is unlikely
>> to be used in new designs. For a product introduction of the QCS615,
>> please refer to
>> https://docs.qualcomm.com/bundle/publicresource/87-83838-1_REV_A_Qualcomm_IQ6_Series_Product_Brief.pdf
> 
> Yes, I guessed so. It would have been nice if it was documented this
> way from the beginning.
> 
> Please note that we usually get support for the mobile SoC first. So
> in most of the cases devices use mobile compatible even for IoT
> platforms, see qrb5165, qrb4210, qcm6490 and other similar platforms.
> I simply asked to follow the established pattern.

Yes, we start from mobile variant for most of the platforms. There are 
some exceptions like sc7180 and sc7280 which we started from compute 
variant since they are widely used by compute platform on upstream 
Kernel. I think we have similar case here. QCS615 will be widely used by 
IOT products on upstream Kernel. We should have clarified this from 
beginning so there's no ambiguity.

> 
>>
>>>
>>>> ---
>>>>    drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 3 +++
>>>>    1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
>>>> index d4fa1063ea61..c56ba8468538 100644
>>>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
>>>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
>>>> @@ -1123,6 +1123,9 @@ static const struct of_device_id qmp_usbc_of_match_table[] = {
>>>>           }, {
>>>>                   .compatible = "qcom,qcm2290-qmp-usb3-phy",
>>>>                   .data = &qcm2290_usb3phy_cfg,
>>>> +       }, {
>>>> +               .compatible = "qcom,qcs615-qmp-usb3-phy",
>>>> +               .data = &qcm2290_usb3phy_cfg,
>>>>           }, {
>>>>                   .compatible = "qcom,sdm660-qmp-usb3-phy",
>>>>                   .data = &sdm660_usb3phy_cfg,
>>>> --
>>>> 2.34.1
>>>>
>>>
>>>
>>
>>
>> --
>> Thanks,
>> Tingwei
> 
> 
> 


-- 
Thanks,
Tingwei