AW: [PATCH v2 1/3] dt-bindings: phy: add realtek,otto-serdes PHY binding
markus.stockhausen at gmx.de
markus.stockhausen at gmx.de
Mon Oct 7 22:38:51 PDT 2024
> -----Ursprüngliche Nachricht-----
> Von: Krzysztof Kozlowski <krzk at kernel.org>
> Gesendet: Montag, 7. Oktober 2024 21:26
> An: Markus Stockhausen <markus.stockhausen at gmx.de>; linux-phy at lists.infradead.org; chris.packham at alliedtelesis.co.nz; devicetree at vger.kernel.org
> Betreff: Re: [PATCH v2 1/3] dt-bindings: phy: add realtek,otto-serdes PHY binding
>
> ... and still not tested. Sending untested code is waste of our time.
Hi Krzysztof,
appreciate your feedback and I do not want to waste your time. My fixes where a mix
of your feedback and some half-baked "make dt_binding_check" feedbacks (because
packages where missing). My fault and sorry fort he noise.
To get next version in better shape two questions regarding your feedback:
1. "Messed wrapping": According to checkpatch 100 chars/line are accepted.
So I designed the comments in the driver. Does devicetree differ from that?
2 "Bindings vs drivers". The idea about controlled ports came from other bindings.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/st,stih407-irq-syscfg.yaml?h=v6.12-rc2
E.g. st,invert-ext. Something like this will be needed in the future because the
SerDes allow to swap polarity which must be changed depending on the switch
design. How to do this?
Best regards.
Markus
More information about the linux-phy
mailing list