[PATCH 5/9] phy: exynos5-usbdrd: fix EDS distribution tuning (gs101)

Peter Griffin peter.griffin at linaro.org
Fri Nov 29 01:22:20 PST 2024


Hi André,

On Wed, 27 Nov 2024 at 10:58, André Draszik <andre.draszik at linaro.org> wrote:
>
> This code's intention is to configure lane0 and lane2 tunings, but for
> lane2 there is a typo and it ends up tuning something else.
>
> Fix the typo, as it doesn't appear to make sense to apply different
> tunings for lane0 vs lane2.
>
> The same typo appears to exist in the bootloader, hence we restore the
> original value in the typo'd registers as well. This can be removed
> once / if the bootloader is updated.
>
> Note that this is incorrect in the downstream driver as well - the
> values had been copied from there.
>
> Signed-off-by: André Draszik <andre.draszik at linaro.org>
> ---

Reviewed-by: Peter Griffin <peter.griffin at linaro.org>
Tested-by: Peter Griffin <peter.griffin at linaro.org>

Validated that a super-speed USB link is established between Pixel 6
phone and my laptop with this patch applied and that adb works.

regards,

Peter



More information about the linux-phy mailing list