[PATCH 1/8] dt-bindings: display/msm: Document DP on QCS615

[Krzysztof Kozlowski]

On 29/11/2024 08:57, Xiangxu Yin wrote:
> Document the DP hardware found on the Qualcomm QCS615 platform.
> 
> Signed-off-by: Xiangxu Yin <quic_xiangxuy at quicinc.com>
> ---
>  .../devicetree/bindings/display/msm/dp-controller.yaml      | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index a212f335d5ffae545d2e5bacec95299ca45e8405..a609245ae601bdc60b65f19d3e59c559886a969d 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -26,6 +26,7 @@ properties:
>            - qcom,sc8280xp-dp
>            - qcom,sc8280xp-edp
>            - qcom,sdm845-dp
> +          - qcom,sm6150-dp

I see sm6150, not qcs615.

>            - qcom,sm8350-dp
>            - qcom,sm8650-dp
>        - items:
> @@ -109,6 +110,18 @@ properties:
>    vdda-1p2-supply:
>      deprecated: true
>  
> +  max-width:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Maximum allowed width for display modes
> +    default: 7680

I don't see why this is a property of board. Drop. Anyway, missing
vendor prefix or unnecessary $ref, if it comes from other schema.

> +
> +  dp-hpd-gpio:

gpios

> +    description: External GPIO for controlling HPD when a 3rd pinctrl is used
> +    items:
> +      - description: phandle to 3rd GPIO controller
> +      - description: GPIO pin number
> +      - description: Optional GPIO flags

Nope, that's not how GPIOs are created. Please take a look at any other
schema.

Anyway, I doubt that you need this property. See common bindings for
display pieces.


Best regards,
Krzysztof