[PATCH v2 1/3] dt-bindings: ufs: qcom: Add UFS Host Controller for QCS615

Xin Liu quic_liuxin at quicinc.com
Thu Nov 21 02:06:06 PST 2024



在 2024/11/21 18:01, Krzysztof Kozlowski 写道:
> On 21/11/2024 09:37, Xin Liu wrote:
>>
>>
>> 在 2024/11/21 15:40, Krzysztof Kozlowski 写道:
>>> On 20/11/2024 17:57, Krzysztof Kozlowski wrote:
>>>> On 19/11/2024 03:20, Xin Liu wrote:
>>>>> From: Sayali Lokhande <quic_sayalil at quicinc.com>
>>>>>
>>>>> Document the Universal Flash Storage(UFS) Host Controller on the Qualcomm
>>>>> QCS615 Platform.
>>>>>
>>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>>>>> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>
>>>>> Signed-off-by: Sayali Lokhande <quic_sayalil at quicinc.com>
>>>>> Co-developed-by: Xin Liu <quic_liuxin at quicinc.com>
>>>>> Signed-off-by: Xin Liu <quic_liuxin at quicinc.com>
>>>> That's a bit odd SoB chain. First, these are just one-liners. Second,
>>>> who authored the patches?
>>> To be clear: SoB regarding authorship is correct, but regarding Acks and
>>> Reviews is not. Savali did not receive these tags. If so, please point
>>> to lore discussion with it.
>>>
>>> All this needs fixing.
>> Thank you for your comments. These are the two reviews I received. One
>> is your reviewd-by, and the other is Manivannan's acked-by.I have also
>> cc Sayali on the email.
>>
>> https://lore.kernel.org/linux-arm-msm/rv3ukz6rhgp3x32s74nbftmoqmdxjxmoii3zsd4wipmhudyq7q@ha4l2svl5lim/
>>
>> https://lore.kernel.org/linux-arm-msm/20241112075619.2ilsccnnk4leqmdy@thinkpad/
> 
> I meant order of tags. Who received them? You, not Sayali. Then they
> cannot be before Sayali SoB.
> 
Thank you for your comments. I will fix it next version.
> 
> Best regards,
> Krzysztof




More information about the linux-phy mailing list