[PATCH v3 1/4] dt-bindings: phy: airoha: Add binding doc for PCIe PHY driver

Lorenzo Bianconi lorenzo at kernel.org
Wed May 29 06:11:33 PDT 2024


> On 18/05/2024 13:31, Lorenzo Bianconi wrote:
> > Introduce device-tree binding documentation for Airoha EN7581 PCIe PHY
> > driver.
> > 
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
> > Tested-by: Zhengping Zhang <zhengping.zhang at airoha.com>
> 
> How the binding was tested?
> 
> > Signed-off-by: Lorenzo Bianconi <lorenzo at kernel.org>
> 
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 
> Subject: drop driver. This is for hardware, not drivers.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>

Do I need to repost it or is it ok to address it applying the patches?

Regards,
Lorenzo

> 
> Best regards,
> Krzysztof
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-phy/attachments/20240529/7cb6f6bf/attachment.sig>


More information about the linux-phy mailing list