[PATCH 3/5] phy: exynos5-usbdrd: make phy_isol() take a bool for clarity

Peter Griffin peter.griffin at linaro.org
Wed Jun 12 01:46:49 PDT 2024


Hi André,

On Tue, 7 May 2024 at 15:14, André Draszik <andre.draszik at linaro.org> wrote:
>
> on / not on is just a boolean flag and is a bit misleading as currently
> on==1 means to turn off the power, and on==0 to turn power on.
>
> Rename the flag and make it a bool to avoid confusion of future readers
> of this code. No functional change.
>
> While at it, fix a whitespace issue in nearby comment.
>
> No functional change.
>
> Signed-off-by: André Draszik <andre.draszik at linaro.org>
> ---

Reviewed-by:  Peter Griffin <peter.griffin at linaro.org>

regards,

Peter

[..]



More information about the linux-phy mailing list