[PATCH v2] phy: cadence-torrent: add support for three or more links using 2 protocols

Siddharth Vadapalli s-vadapalli at ti.com
Mon Jul 15 21:04:02 PDT 2024


On Mon, Jul 15, 2024 at 07:08:30PM +0300, Roger Quadros wrote:
> Hi Siddhath,
> 
> On 12/07/2024 13:38, Siddharth Vadapalli wrote:
> > Roger, Swapnil,
> > 

[...]

> > So assuming the above, we can enforce the constraint that there should
> > be only 2 Protocols when 3 or more Links are present in the device-tree.
> > This also handles the cases of
> > PCIe Multi-Link + USB, PCIe Multi-Link + Q/SGMII
> > which Swapnil has pointed to at [1], since PCIe Multi-Link is now a new
> > protocol in itself (PHY_TYPE_PCIE_ML) and shall be represented in that
> > manner in the device-tree when it is expected to be combined with a second
> > protocol.
> > 
> > After grouping the links by protocol, we can check for the entry in
> > "link_cmn_vals_entries" and proceed to configure it identical to the
> > 2 Link case.
> > 
> > [1] https://github.com/t-c-collab/linux/commits/ti-linux-6.1.y-torrent-multi-pcie-sgmii-v1
> 
> This proposal looks good to me. Thanks!

Thank you for the confirmation. I will implement the above in the v3
patch.

Regards,
Siddharth.



More information about the linux-phy mailing list